Daniel Mentiplay

Results 11 issues of Daniel Mentiplay

Hi @tommyod. First, thanks very much for KDEpy! I use KDEpy as part of my smoothed particle hydrodynamics analysis and visualisation software Plonk (https://github.com/dmentipl/plonk). I use it for interpolation of...

It would be good to add a reference to isort and flake8 in the developer guide. For example [here](https://improver.readthedocs.io/en/latest/Code-Style-Guide.html#code-formatting). Related: #1462, #1465, #1466

good first issue

A new version of cf-units (3.0.0) has been released with breaking changes: [release notes](https://github.com/SciTools/cf-units/releases/tag/v3.0.0). This leads to 48 unit test failures in IMPROVER. I discovered this during testing with the...

As part of the update to using Iris 3 (see PR #1507) I discovered new unit test failures in changing from NumPy 1.20.* to 1.21 (see [here](https://github.com/metoppv/improver/pull/1507#issuecomment-866567034) for where they...

#1448 added type annotations to IMPROVER functions and method signatures (except those in the CLIs which already use type annotations for clize). #1448 also added running the type checker mypy...

Accessing a particle array on a snapshot is currently lazy, in the sense that the data is only loaded from disc into memory when requested, e.g. with `snap['position']`. However, it...

enhancement
help wanted

Phantom has integer codes `ieos` that determine the equation of state (eos). These codes are written to the snapshot file header. These are required to calculate the temperature or pressure...

enhancement

Currently, the low-level SPH interpolation routines live in [`splash.py`](https://github.com/dmentipl/plonk/blob/master/plonk/visualize/splash.py). These are rewritten from the original [Splash](https://github.com/danieljprice/splash) Fortran routines using NumPy and Numba for performance. The package [sph-interp](https://github.com/dmentipl/sph-interp) contains very similar...

### Is your feature request related to a problem? Please describe This function is to replicate the functionality of Phantom's moddump. ### Describe the solution you'd like A new module/class/function...

enhancement

Currently the only Phantom header quantities read in are 'time', 'udist', 'utime', 'umass', 'hfact', 'ieos', 'gamma', 'polyk', 'qfacdisc'. Other quantities may be required.

enhancement