Derek McGowan
Derek McGowan
@paralin can you add a little bit more context to this issue. We don't currently have any ongoing efforts to support `GOOS=js` or issues tracking it. Knowing more about the...
@paralin if this library is being used for a platform other than what is explicitly supported, our normal pattern is to include a `console_other.go` file which builds with `!` statements...
The change looks OK to me. Given the time its been since changes were made here, I think I would like to see where this change is used and how...
Going to close this one for now, would love to see an example of this done as a service though
You have probably spent more timing thinking about it than me. What are some of the downsides of having it as a side-channel service? I might be looking at this...
Hmm, we should really have a prefix option for doing label filters, like today you could do `ctr content ls 'labels."containerd.io/gc.ref.content.l.1"==sha256:48d9183eb12a05c99bcc0bf44a003607b8e941e1d4f41f9ad12bdcc4b5672f86' but no way to just match on the gc.ref.content...
Content can be held by any other type including containers, sandboxes, images, snapshots, leases, content, and ingests. See everywhere https://github.com/containerd/containerd/blob/main/metadata/gc.go#L745 is called. Images, labels and ingests will directly hold onto...
> Especially since containerd has been around for years and the grammar is only in the code comment, I don't want to make the implementation more strict, especially in 1.x...
> I think that quotes are necessary for the label. This implementation only allows the '-' as valid in the label but does not remove quotes from the label. The...
@kiashok In the last refactor of cri images this could be much simpler now. We can scope this initial change to adding multi-platform support to `pkg/cri/server/images` and updating the necessary...