Derek McGowan

> call the APIs in the client directly, so that we don't need to find the Controller everytime we need to call APIs of sandbox controller. I'm hesitant on this...

I am fine making this optional, my concern is without this check there is no commit sanity check that what was written matches what was received. Since the registry is...

Is there a user impact worth considering here? There is already an alternative we support, are there a considerable number of images or something out there still generating them? Its...

Use https://github.com/containerd/containerd/blob/main/remotes/docker/errcode.go which we already have to decode these error types. The decoding of these error codes should handle before it gets to the unexpected error type, this type is...

@alam0rt What build of containerd are you using? I was wondering how the types could conflict since a panic will occur with multiple registrations. However, typeurl, gogoproto, and protobuf packages...

I think this makes sense for 2.0. How would we want to backport support for this to 1.6/1.7? We would want to utilize the deprecation warnings there now too.

For the failure, update the 1.6 and 1.7 config to match the new default at https://github.com/containerd/containerd/tree/main/integration/client/testdata . I have been adding a comment and keeping the original value so we...

> images that have the RootFs in the snapshot but have a different digest in their oci config What is this referring to and where is the difference? In your...

I agree with @imeoer that the correct solution for the specific error is `discard_unpacked_layers=false`. Long term, we really need to know the target snapshotter the pull is for if `discard_unpacked_layers=true`...

> When using uk.icr.io/armada-master/ingress-alpine:3.18_249 and alpine:3.18.0 we have a case where two blobs of content from the remote repositories unzip to the same bits. sha256:8a49fdb3b6a5ff2bd8ec6a86c05b2922a0f7454579ecc07637e94dfd1d0639b6 from alpine:3.18.0 and sha256:bc01fbd705408cb3b447eb0ad4059bf08f686442be80e65dd951ce884b64a595 from...