Derek McGowan

Results 319 comments of Derek McGowan

There is a pending fix for the http handler on the containerd side that we can wait for in 1.7 before updating this one. Also on another look I'm not...

Pushed an update the fixes I mentioned. As for the containerd fix, we need to handle TLS handshake timeouts (see https://github.com/containerd/containerd/issues/10014). Although the current version we have also has this...

Rebased but we don't need to consider this for 27 for the fix. The fix for #47240 was included in the latest buildkit update with https://github.com/moby/buildkit/pull/4975. We can consider the...

I think we want to be careful with this one and probably implement it not as CRI specific way or trying to re-use docker credential helpers. The credential helper model...

I'm going to close this, we should only put stuff into `pkg` once we have a clear idea for what that package should be. In this case, the deep copy...

Please verify with the latest v2.0.0-rc.1 that this has been fixed

When includes are involved there are likely multiple thrift interfaces sharing the include, if you generated the include package automatically you may end up generating it twice. Would it be...

I am also in favor of finding an alternative to tar. The only issue I have with git is the use of sha-1 requires having additional hashing on top of...

Agree it makes sense to do 1 since it is clearly expecting a usage calculation by passing in the directory. In general "size" is a tricky topic for images because...