Derek McGowan
Derek McGowan
Closing due to inactivity, feel free to re-open the pull request anytime if you continue working on this.
Change looks good, what is remaining to get this in?
If this change is still needed, open up at https://github.com/containerd/platforms
Thank you for the contribution! Please sign your commit using `git commit -s`, see https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work Also for this module file, I'm wondering if we could add it to contrib. We...
@aojea related to changing spdystream... Are you suggesting here just avoiding the idle reset when a ping frame is set? https://github.com/moby/spdystream/blob/master/connection.go#L161 I think that change seems reasonable, but not sure...
I think the plugin approach from #5105 was proposed that way because we don't put auth info into any of our core interfaces and for good reason. The static auth...
> I use nerdctl with --restart=always to run a container,then use nerdctl stop it,but this container still auto start. Why not use `unless-stopped` though? I understand trying to replicate some...
What type of config information?
> Guard io.Writer in progressOutput with a mutex What is the issue seen for this? Is `prog.LastUpdate` not actually the last update or is the writer itself not protected?
Marked this as ready to go. I fixed the authorizer with the containerd image service resolver. The other failures now don't seem related, look like flakes.