Damien Mathieu

Results 259 comments of Damien Mathieu

@cpuguy83 this issue has been waiting for your answer for a few months. Can it be closed?

Do you need to pass spans between processes? If each process is able to export the spans it creates, then you could setup some custom [propagator](https://opentelemetry.io/docs/specs/otel/context/api-propagators/) which would allow creating...

I feel like that may be an edge case, so you may be better off setting up something of your own rather than having something supported by otel. In any...

> Already implemented: Your link is setting attributes for the spans, not metrics.

I believe adding a test would make the review easier.

Feel free to open a PR and link this issue on it.

Sorry for the lack of response here. Approving this new instrumentation would require more details, especially with the documentation provided here: https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation#new-instrumentation

Note that the 1.21.0 semantic conventions recommend the use of an environment variable to make this transition smoother. https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/http/README.md Not all SDKs are following this recommendation (it's a SHOULD, not...

You will need to sign the CLA, add a changelog as well as tests.

See also https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4046 I'm not opposed to renaming the span (or removing it). The current behavior is also, IMHO, correct, since the net/http documentation states the response body should always...