Damien Mathieu

Results 196 comments of Damien Mathieu

Sorry I didn't see it before, but this PR will conflict with #3585.

I don't have a preference either. I guess it really depends on when a maintainer does the merging.

We will indeed need to implement it, as it's specified. Feel free to let us know if you want to start working on it, or just to open a PR.

I would call the method `WithHeaders`, as we do with [the otlp exporter](https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/otlp/otlptrace/otlptracegrpc/options.go#L108) but outside of that, it seems like a good idea.

Thank you @trask. Yes, this should be what we need. We'll be looking into it. In the mean time, I do believe this issue can be closed.

My thinking at this point is that both metrics and traces would be enabled by default, with options to disable them.

For additional context on what prompted me to open the original otep, the current behavior means whenever we retrieve a span from the context, we need to check if we're...

Our spans have arbitrarily wide events. And the more data/context they have, they more we're able to figure things out from them. So yes, we add lots of attributes on...

I don't believe this has been picked up. There's no specific reason outside of other priorities. Feel free to open a PR.

Closing this PR as stale, and with conflicts that were not resolved.