opentelemetry-go
opentelemetry-go copied to clipboard
[doc] replace ` jaeger exporter` with `otlp http exporter`
Signed-off-by: Peter Liu [email protected]
Resolve https://github.com/open-telemetry/opentelemetry.io/issues/1567
Sorry I didn't see it before, but this PR will conflict with #3585.
Sorry I didn't see it before, but this PR will conflict with #3585.
@Petrie happy to work with you getting 3585 and your PR here merged together.
Sorry I didn't see it before, but this PR will conflict with #3585.
@Petrie happy to work with you getting 3585 and your PR here merged together.
I understand a conflict will occur when pr https://github.com/open-telemetry/opentelemetry-go/pull/3585 get merged. But i am a little confused , anything else should I do to avoid the confilct? @damemi @svrnm
Sorry I didn't see it before, but this PR will conflict with #3585.
@Petrie happy to work with you getting 3585 and your PR here merged together.
I understand a conflict will occur when pr #3585 get merged. But i am a little confused , anything else should I do to avoid the confilct? @damemi @svrnm
I think there's 2 ways to go about that:
- one PR gets merged first and the other one needs to fix the conflict
- one PR gets incorporated into the other one first (via a PR to the forked branch)
I'll leave it to @dmathieu to guide us here :-) I'm ok if we merge them sequentially and one of us needs to do some extra work (can be me)
I don't have a preference either. I guess it really depends on when a maintainer does the merging.
Ok, I get it. I'll wait. I think it's a simple conflict. if it is possible, I'll take care of it.
Ok, I get it. I'll wait. I think it's a simple conflict. if it is possible, I'll take care of it.
thank you!
Codecov Report
Merging #3705 (8e5dda4) into main (90df525) will decrease coverage by
0.1%. The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@
## main #3705 +/- ##
=======================================
- Coverage 81.8% 81.7% -0.1%
=======================================
Files 169 169
Lines 12855 12855
=======================================
- Hits 10517 10513 -4
- Misses 2119 2123 +4
Partials 219 219