opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

[doc] replace ` jaeger exporter` with `otlp http exporter`

Open Petrie opened this issue 2 years ago • 8 comments

Signed-off-by: Peter Liu [email protected]

Resolve https://github.com/open-telemetry/opentelemetry.io/issues/1567

Petrie avatar Feb 10 '23 13:02 Petrie

Sorry I didn't see it before, but this PR will conflict with #3585.

dmathieu avatar Feb 13 '23 16:02 dmathieu

Sorry I didn't see it before, but this PR will conflict with #3585.

@Petrie happy to work with you getting 3585 and your PR here merged together.

svrnm avatar Feb 14 '23 08:02 svrnm

Sorry I didn't see it before, but this PR will conflict with #3585.

@Petrie happy to work with you getting 3585 and your PR here merged together.

I understand a conflict will occur when pr https://github.com/open-telemetry/opentelemetry-go/pull/3585 get merged. But i am a little confused , anything else should I do to avoid the confilct? @damemi @svrnm

Petrie avatar Feb 14 '23 10:02 Petrie

Sorry I didn't see it before, but this PR will conflict with #3585.

@Petrie happy to work with you getting 3585 and your PR here merged together.

I understand a conflict will occur when pr #3585 get merged. But i am a little confused , anything else should I do to avoid the confilct? @damemi @svrnm

I think there's 2 ways to go about that:

  • one PR gets merged first and the other one needs to fix the conflict
  • one PR gets incorporated into the other one first (via a PR to the forked branch)

I'll leave it to @dmathieu to guide us here :-) I'm ok if we merge them sequentially and one of us needs to do some extra work (can be me)

svrnm avatar Feb 15 '23 08:02 svrnm

I don't have a preference either. I guess it really depends on when a maintainer does the merging.

dmathieu avatar Feb 15 '23 08:02 dmathieu

Ok, I get it. I'll wait. I think it's a simple conflict. if it is possible, I'll take care of it.

Petrie avatar Feb 15 '23 14:02 Petrie

Ok, I get it. I'll wait. I think it's a simple conflict. if it is possible, I'll take care of it.

thank you!

svrnm avatar Feb 28 '23 08:02 svrnm

Codecov Report

Merging #3705 (8e5dda4) into main (90df525) will decrease coverage by 0.1%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3705     +/-   ##
=======================================
- Coverage   81.8%   81.7%   -0.1%     
=======================================
  Files        169     169             
  Lines      12855   12855             
=======================================
- Hits       10517   10513      -4     
- Misses      2119    2123      +4     
  Partials     219     219             

see 2 files with indirect coverage changes

codecov[bot] avatar Mar 21 '23 14:03 codecov[bot]