David Matějček comments

Results 181 comments of


                                            David Matějček

Remove all finalize() method calls or overrides

> > * Should be replaced by proper lifecycle or AutoCloseable calls. > > Third option is `java.lang.ref.Cleaner` Thanks, I added it to the description.

Fix GF Embedded runtime detection and unify the working approaches to detect runtime

I am not sure, but the term "embedded" can mean 2-3 different things in GlassFish terminology, as it evolved over years. In our usual usage the ServerEnvironment.isEmbedded is the right...

Fix GlassFish static shell bootstrap setup

Static is not really embedded, it is rather a bastard made just for few TCK tests if I remember well. It should not be used at all, and maybe for...

Fix GlassFish static shell bootstrap setup

Aha, I was wondering what was the motivation behind this, I do remember we were talking about it.

AutoDisposableGlassFish failure: no CommandRunner implementation available

Related a bit with #25790 , because I was surprised by this again. At least, I would like to understand what is the problem here, and probably fix it. Why...

HTTP Pool monitoring should be enabled by the thread-pool monitoring module, not by the http-service module

I would expect any thread pool in the UI listed under thread pools should be printed here.

Embedded GlassFish doesn't remove temporary directories if dispose() not called

> I created another issue to fix the test and avoid leaving temporary directories after the test suite is executed: [#25607](https://github.com/eclipse-ee4j/glassfish/issues/25607) Probably would be good if the test would be...

Embedded GlassFish doesn't remove temporary directories if dispose() not called

No, I am right. GHA on Windows is bit more hysterical about it ... First in the issue I just noticed those files, but not the reason why they remain...

Embedded GlassFish doesn't remove temporary directories if dispose() not called

Yeah, I am using Linux, so even there it can happen. Partially it is also because many tests still don't use `@TempDir`, but another part might be resource leaks or...

Corba refactoring

FIXME: In #25790 I have collided with incorrect CORBA lifecycle, which can leave "zombie ports" open after shutdown. I added just some fixme to the code, and three partial workarounds...