eclipse-ee4j
Fix GlassFish static shell bootstrap setup
- Was missing several JARs in the JAR classpath after they were relocated earlier
- Behaved as DAS. Now behaves as Embedded
- Added static shell as another target for Embedded tests
There are tests failing related to Embedded GF in normal server. Looks like the Embedded runtime is also used in server in some obscure scenario. I will need to find a better way to detect when EmbeddedGlassFishRuntime runs as a static shell and should report Embedded in the environment.
@dmatej, do know know under which situation is EmbeddedGlassFishRuntime used in Server (not Embedded GlassFish) ?
Static is not really embedded, it is rather a bastard made just for few TCK tests if I remember well. It should not be used at all, and maybe for those TCKs we should enforce real embedded jar instead and kill this monster. It is a monster because it uses "random" jar files and files spread over standard Eclipse GlassFish server. I guess server doesn't use it at all ...?
Hi, @dmatej , I only care about static shell because our Docker image allows using it as runnable embedded GlassFish, using the same image as for server. We should really have a separate docker image for Embedded GlassFish, then we don't need static shell at all.
So, I'll move this PR on hold (draft) just as a reminder and we should create an Embedded GlassFish docker image. I'll close this PR afterwards.
Aha, I was wondering what was the motivation behind this, I do remember we were talking about it.