Devis Lucato
Devis Lucato
could we simplify further, avoiding the class? ```python def runThread(code): x = threading.Thread(target=code) x.start x.join return x.result ``` ```python if loop and loop.is_running(): if self.is_semantic: return runThread(self._invoke_semantic_async(context, settings)) else: return...
@mkarle yes that looks better, using methods and not having an extra class is nicer. nitpicking, is it possible to write `thread.start().join()` or somehow combine the 2 lines? anyhow, pls...
@dmitryPavliv we are considering to expose the underlying full power of the models, it might be via a different set of interfaces though. IChatCompletion and ITextCompletion are aimed at the...
hi @alexandrereyes thanks for looking into this, yes we're aware of the issue and we plan on start using IHttpClientFactory shortly. The work fits into a bigger story that covers...
@hathind-ms @craigomatic FYI
as per @lemillermicrosoft the fix will be integrated into #523
@ScottKane thanks for bringing this in! Unfortunately you unchecked the "allow maintainers to edit the PR" and we could not address some important changes, e.g. the dependency on an old...
1. rename for clarity 2. remove T from base class, no impact
thanks, I'll look into this. By the way we're also working on a new tokenizer, bringing in tiktoken, would love having this kind of contributions when we're ready :-)
options: * P1: max size, hardcoded or configurable * P2: allow to throw away the cache, e.g. keep it in the instance