David L. L. Thomas

Results 10 comments of David L. L. Thomas

Ah, missed that, awesome. I'll play around and see if there's any changes I want to make. Thanks for the great library! :)

I don't expect Uber has enough interest in MS SQL support to implement it internally, but I'm sure they'd be happy to merge new dialects if provided (@h4v0kh3l1 can you...

If memory serves, in the early days of trying to figure out how we were going to get it running on Uber infrastructure I got it working with HaPy (handing...

So far as I'm aware, parsing speed hasn't been an issue. Moving to megaparsec might be good, but should be weighed against "if it ain't broke" (it was fairly new...

Two other notes: 1. Choice of parsing library could be per-dialect with minimal drawbacks, so migration could be gradual or limited to new packages (or not - just worth noting...

We could give the [Hive](https://github.com/uber/queryparser/blob/master/dialects/hive/src/Database/Sql/Hive/Type.hs#L59) type a type-level version parameter.

The python code involved in the project was very Uber-specific and not very queryparser or Haskell specific at all - it would mostly naively forward Thrift messages to a Haskell...

@etrabelsi In response to @h4v0kh3l1's comment (https://github.com/uber/queryparser/issues/32#issuecomment-387531103): That sounds about right. There's also the option of working from the grammar for the dialect, if you have it, as Matt did...

https://github.com/LeapYear/queryparser/commits/leapyear-master has some Teradata support, although I broke the catalog defaulting, so depending on your needs there may still be work to do. In answer to your questions: 1. With...

Depending on how strict the formatter, we may not care about the original whitespace. We should clearly preserve comments, though. On Wed, Apr 4, 2018 at 11:16 AM, Heli Wang...