Dave Marion

Results 422 comments of Dave Marion

I'm going to kick off a Full IT build as a sanity check

@EdColeman - 2 approvals, can we merge this?

Closing this for now as I'm not sure that adding AutoCloseable to the CryptoService is the right thing to do.

No, punt to next release

@keith-turner - I implemented your changes. I kind of expected a test failure, but that didn't happen. Update: I found that I had to make a similar change in GarbageCollectionTest,...

@keith-turner - I like it. Can you create a PR against my branch and I will merge it in?

Nevermind, I grabbed the [diff](https://github.com/keith-turner/accumulo/commit/78cf05d9af90bb7ba218a17cda6755df80127702.diff) and applied manually

> So, I'm not convinced this is the right approach. What's the implication of this statement? Are you saying that we need to go back to the drawing board? If...