accumulo icon indicating copy to clipboard operation
accumulo copied to clipboard

Renaming ZooStore get/set property methods to get/set nodeData

Open cshannon opened this issue 3 years ago • 2 comments

Also using a new enum type for the node names instead of String values.

This closes #2841

cshannon avatar Aug 02 '22 22:08 cshannon

@EdColeman - Here is my first attempt at renaming the methods and using an enum. Per our discussion offline I renamed the "debug" property to "target" as it's a better description of what it is. Obviously any of those names can be changed or tweaked based on what people think. I didn't add any new tests as I figure the existing Fate tests should catch any issues with the ZooStore and refactoring.

cshannon avatar Aug 02 '22 22:08 cshannon

@EdColeman - Thanks for the quick review, I'll look at making these changes when I get some time later this week either tomorrow or this weekend.

cshannon avatar Aug 02 '22 23:08 cshannon

@EdColeman and @dlmarion - I updated my PR with a new commit to address the comments. I renamed the enum to TxInfo and the methods. Also another change is the enum name is used as is now when storing data into ZK which is all caps instead of lower case (this can be changed of course but seems ok to me).

cshannon avatar Aug 06 '22 16:08 cshannon

Looks good but there were a few references to old name (property) still hanging around in the javadoc.

Thanks, I can fix those tomorrow morning and then we can hopefully get this merged in.

cshannon avatar Aug 11 '22 18:08 cshannon

@milleruntime - Ok I added a new commit to fix the Javadoc and enum. (I also rebased off main to make sure no conflicts or issues). This should be ready to merged into main I think.

cshannon avatar Aug 12 '22 11:08 cshannon

I'm going to kick off a Full IT build as a sanity check

dlmarion avatar Aug 12 '22 12:08 dlmarion

Full IT build passed

dlmarion avatar Aug 12 '22 17:08 dlmarion