Daniel Lipovetsky

Results 82 comments of Daniel Lipovetsky

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

A different test, ["Should successfully create a cluster with machine pool machines"](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3763/pull-cluster-api-provider-aws-e2e-blocking-release-1-5/1579923293723430912#1:build-log.txt%3A2297) failed. It passed the first run. I'll re-run again.

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

This PR only affects managed (EKS) clusters, but the failing tests in `pull-cluster-api-provider-aws-e2e-blocking-release-1-5` have all been for an unmanaged cluster.

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

@sedefsavas I think this is worth merging into release-1.5 We can decide separately whether or not to release 1.5.1

It looks like the maintainer approval has no effect because the https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-aws-maintainers is not up to date. I'll raise this on slack. Update: We'll be able to approve once we...

Just for reference: Requiring TLS >= 1.2 will **not** cause any issues for FIPS compliance. FIPS already requires 1.2 as the minimum version. The clearest reference I found is this...

@Promaethius I noticed you assigned yourself a few months ago. Are you still working on this? I'd like to help move this idea forward.

Related to https://github.com/kubernetes-sigs/cluster-api/issues/5517