cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
[release-1.5] fix: use v1beta1 version in EKS user kubeconfig
This is an automated cherry-pick of #3740
/assign dlipovetsky
There's a failure in the should create cluster with nested assumed role test. I see the same failure for an older backport PR, #3632.
I don't see any changes in this PR, or between release-1.5 and main, that appear to be related to the test failure.
I'll re-run the test.
A different test, "Should successfully create a cluster with machine pool machines" failed. It passed the first run.
I'll re-run again.
This PR only affects managed (EKS) clusters, but the failing tests in pull-cluster-api-provider-aws-e2e-blocking-release-1-5 have all been for an unmanaged cluster.
@sedefsavas I think this is worth merging into release-1.5
We can decide separately whether or not to release 1.5.1
It looks like the maintainer approval has no effect because the https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-aws-maintainers is not up to date. I'll raise this on slack.
Update: We'll be able to approve once we backport the maintainer metadata to release-1.5 (https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3807)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Ankitasw, richardcase, Skarlso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [richardcase]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
