Daniel Lipovetsky

Results 82 comments of Daniel Lipovetsky

For refrerence, the `"failed to wait for \"capi-quickstart\" ELB deletions: timed out waiting for the condition"` error originates here: https://github.com/kubernetes-sigs/cluster-api-provider-aws//blob/8a81ce6890e5728d4c23f95363643b10ab89efb6/pkg/cloud/services/elb/loadbalancer.go#L142-L157 Something to note is that this code lists the ELBs...

> a mechanism to inject a CA Certificate into the certificate bundle that will be used to make AWS API requests. This is the mechanism we need in order to...

> Wondering if using this in conjunction with #2787 might help since the clusters with the vanity URL would have an empty `name`. shrug #2787 lets the user define their...

@Nuru I could not reproduce the error by doing the following: ``` helm2 install --name foo stable/tomcat --version 0.4.0 helm3 2to3 convert foo helm3 2to3 cleanup --release-cleanup --skip-confirmation helm3 upgrade...

Thanks for fixing this, @aniruddha2000! Since I can't reproduce this bug with clusterctl 1.1, I think it was introduced in 1.2. I think this merits a backport. /cherry-pick release-1.2

@fabriziopandini This looks ready to be approved :pray:

I started work on this in https://github.com/dlipovetsky/cluster-api/tree/dlipovetsky/verbose-filters-v1alpha4. I didn't have time to stick with it. I'd be happy to collaborate with you, if you'd like, @RaghavRoy145 .

In today's CAPA meeting, @randomvariable mention that for this to be usable, CAPI needs to support multiple cluster endpoints (https://github.com/kubernetes-sigs/cluster-api/issues/5295). Does that sound right to you, @AverageMarcus?

There's a failure in the [`should create cluster with nested assumed role` test](https://github.com/mesosphere/cluster-api-provider-aws/blob/8f4a78422af77744c54173061a8807e63da5d1e9/test/e2e/suites/unmanaged/unmanaged_functional_test.go#L163). I see the same [failure](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3632/pull-cluster-api-provider-aws-e2e-blocking-release-1-5/1554052619813523456) for an older backport PR, #3632. I don't see any changes in...