Daniel Lipovetsky

Results 167 comments of Daniel Lipovetsky

Sounds good. We can try to decrease the impact of the change. Some ideas: 1. Write a user-friendly release note that explains how to enable de-duplication when creating the client....

The merge implementation is from https://github.com/containerd/containerd/pull/3574. There is a conversation in that PR about getting the merge right, and it looks like this approach won out: > What about just...

> Are finalizers considered an implementation detail, would it really be a breaking change to change the value if each controller has the correct logic to migrate from old to...

In the meantime, we are hiding "finalizer name" warnings for finalizers for the `cluster.x-k8s.io` group by default in: - the clusterctl `move` command (https://github.com/kubernetes-sigs/cluster-api/pull/11129) - the core controllers (https://github.com/kubernetes-sigs/cluster-api/pull/11242) When...

Related to #5005, where the user asked if changing the field is supported. We did not say yes or no. But it's clearly not supported yet.

Has anyone demonstrated that an in-place upgrade of a single control plane is even possible in a way that is supported by upstream? (For example, node drain is a required...

From office hours today: - Can the manager's `--watch-filter` flag address this use case? - Increased granularity increases the possible test matrix, and given that this is not a common...

An implementation that aggregates errors from multiple handlers would have to merge handler responses., and I don't see a unambiguous way to do that.

/remove-lifecycle rotten It turns out that the API server itself does not return errors from all validating webhooks:https://github.com/kubernetes/kubernetes/issues/132637. We're working on a solution to that. Once we're done, I think...

Thanks for the unit tests @nojnhuh!