Daniel Lipovetsky

From today's office hours: We'd like to have more maintainers/reviewers familiar with the current release process before changing this. /milestone v2.5.0

/triage accepted /priority important-soon

Thanks for this. The change looks good. I noticed this file has no unit tests. In my experience, unit tests are especially helpful for functions that transform data. Would you...

On second thought, this PR has been open for a while, and I don't want to add a new requirement this late. But a unit test would help future maintenance....

/area testing /retitle "[e2e] "imagePullPolicy: Always" and "--metrics-bind-addr=127.0.0.1:8080" replacements not needed anymore?" /triage accepted /kind cleanup /priority important-longterm

From triage 12/2022: Let's add to agenda for next office hours. Core CAPI MachineDeployment does not support multiple failure domains. Please see https://github.com/kubernetes-sigs/cluster-api/issues/3358. We'll hold off on applying /triage label...

I will check the AMI used for this test. There is a known issue with a newer cloud-init version that is affecting recently built Ubuntu 20.04 AMIs.

Subnets are divided into public and private [here](https://github.com/kubernetes-sigs/cluster-api-provider-aws//blob/af2a59e0089feb21a7911019fad2183cc2cd8d4e/pkg/cloud/services/network/subnets.go#L253-L277). I'm ok with a simple API that supports two choices (mostly public, or mostly private), but I think we need to clearly...

@tingchienc Sorry that you're having an issue creating a CAPA EKS cluster. It's clear that you are unable to deploy the worker nodes, but I don't see a clear CAPA...

/priority awaiting-more-evidence