Da Li (李达) comments

Results 48 comments of


                                            Da Li (李达)

skip `raise` basic blocks in `verifyFanoutBackward`

Has a format issue. Will install pre-commit to solve it

skip `raise` basic blocks in `verifyFanoutBackward`

fixed the C++ format issue.

skip `raise` basic blocks in `verifyFanoutBackward`

Gentle cc @sklam , ready for review again.

skip `raise` basic blocks in `verifyFanoutBackward`

Can this be marked with next release milestone?

let typing be compatible with python 3.8

Sure! I can do that. BTW, need to ask first: does prefect want to accept this PR, given python 3.8 will go to the end of its lifecycle in Oct,...

Return object references from tasks?

Same here! I also have a prefect flow based on RayTaskRunner, if the job is only running with Ray, its memory usage is ~500GB, but when using with prefect and...

Extend cache invalidation to include changes in other files (take 2)

Hi, does anyone have time to review this? I can give my preliminary review first, since this patch is really useful! Having it can avoid our pains when we use...

Extend cache invalidation to include changes in other files (take 2)

Got it. I tested it locally, really cool to have it!

Extend cache invalidation to include changes in other files (take 2)

Ah, I found another important bug about this PR, besides my comments above. will give a reproducer later. It seems failed to recognise one kind of `local import` into a...

Extend cache invalidation to include changes in other files (take 2)

With this https://github.com/numba/numba/pull/9168, we can add `BoundFunction` (i.e., `overload_method`'s type template) in `dep_types` in caching.py. Then add some implementations for handling this type, then we can detect `overload_method` related cache...