llvmlite
llvmlite copied to clipboard
skip `raise` basic blocks in `verifyFanoutBackward`
I provide a potential fix for #1023 . But I can't prove it in theory, maybe you can give a counterexample against this PR. Will provide a test case for this.
fix #1023
Hi, I added a test case for this. I guess it's ready for review. I believe @sklam can give it a review if available.
On main branch w/o this patch, this new test case will fail.
I rebuilt llvmlite locally with this patch, and the Numba test suite passed for me.
Thanks, graham! This can be marked as ready for review
I think.
RE: https://github.com/numba/llvmlite/pull/1025#discussion_r1458090545 No, this pattern comes from #1023. I didn't share the real code for this, since it's too big, and don't how to get an example from it. But I think this patch is kind of general.
Has a format issue. Will install pre-commit to solve it
fixed the C++ format issue.
Gentle cc @sklam , ready for review again.
Can this be marked with next release milestone?