llvmlite icon indicating copy to clipboard operation
llvmlite copied to clipboard

skip `raise` basic blocks in `verifyFanoutBackward`

Open dlee992 opened this issue 1 year ago • 7 comments

I provide a potential fix for #1023 . But I can't prove it in theory, maybe you can give a counterexample against this PR. Will provide a test case for this.

fix #1023

dlee992 avatar Dec 23 '23 17:12 dlee992

Hi, I added a test case for this. I guess it's ready for review. I believe @sklam can give it a review if available.

On main branch w/o this patch, this new test case will fail.

dlee992 avatar Jan 15 '24 16:01 dlee992

I rebuilt llvmlite locally with this patch, and the Numba test suite passed for me.

Thanks, graham! This can be marked as ready for review I think.

dlee992 avatar Jan 18 '24 18:01 dlee992

RE: https://github.com/numba/llvmlite/pull/1025#discussion_r1458090545 No, this pattern comes from #1023. I didn't share the real code for this, since it's too big, and don't how to get an example from it. But I think this patch is kind of general.

dlee992 avatar Jan 18 '24 23:01 dlee992

Has a format issue. Will install pre-commit to solve it

dlee992 avatar Jan 29 '24 20:01 dlee992

fixed the C++ format issue.

dlee992 avatar Feb 27 '24 20:02 dlee992

Gentle cc @sklam , ready for review again.

dlee992 avatar Feb 27 '24 20:02 dlee992

Can this be marked with next release milestone?

dlee992 avatar Mar 28 '24 15:03 dlee992