Doug Clark

Results 12 comments of Doug Clark

Thanks for submitting this! It'll take me a bit to review and gather my thoughts on it.

Oddly enough I think this one is related to #34. The `()+?` construct generates a state machine that ends up with a corrupt stack. I suspect the `Lazybranchmark` operation isn't...

This one is a head-scratcher. I've confirmed it happens in the .NET regex engine that `regexp2` is based on. During the second match it seems like the regex stack is...

Worth a shot https://github.com/dotnet/runtime/issues/43314

I’m assuming gostd.regexp is the go standard library regexp package. This package isn’t designed to be a drop-in replacement for the standard library. At first blush a conversation layer doesn’t...

Sure! Be sure to document the compatibility goal in the README and include tests.

@gandarez What exact input and options cause the pattern to panic? It'd help to have a simple test reproducing the problem.

What are the specs of the machine running the tests? This test works on my machine (go v1.21.4), but I could imagine that for very slow machines the timing may...

Is this still consistently happening?

Hey, thanks for this. I have a few notes: - I'd like to see tests for all the impacted shortcuts code paths, `\d` `\s` `\w` `\p` - The inRange flag...