Vladislav Balabanov

Would be nice to rename/deprecate method name 'getIpFromRequest' and add something like `getKeyFromRequest`, because custom guards may not use IP as key, so such method name a bit misleading.

https://github.com/ozkanonur/nestjs-rate-limiter/blob/master/lib/rate-limiter.guard.spec.ts is equal to https://github.com/ozkanonur/nestjs-rate-limiter/blob/master/lib/rate-limiter.decorator.spec.ts, so guard tests missed.

Problem with non ascii username submission

7

python 2.7 Django 1.8.13 django-defender 0.4.2 I cannot cleanup username filed, because defender handle post data before form validation, so if user submit non ascii username - defender raise UnicodeEncodeError...

_Originally posted by @dlancer in https://github.com/dxxb/sim-arduboy/issues/18#issuecomment-434221481_

Game Ardynia do not start

1

Game Ardynia do not start: https://github.com/city41/ardynia 1. Just black screen and nothing in the logs with current simavr-arduboy build. 2. With simavr updated to the latest and your spi related...

sys.exit function allow string argument, so [do_exit()](https://github.com/fabioz/PyDev.Debugger/blob/master/pydevconsole.py#L247) function throw TypeError if we use string.

wrong sys.exit argument

6

line 118: `` sys.exit("""DEBUG is False but no SECRET_KEY is set in the environment - either it has been hardcoded (bad) or not set at all (bad) - exit()ing for...