Tong Mu

Results 72 comments of Tong Mu

The code is assuming that `TestWidgetsFlutterBinding.instance.renderViewElement` is never null. It's easy for me to loosen the assertion (resulting in a null for `innerTargetElement`), but this is probably wrong, and will...

I tried to come up with https://github.com/flutter/flutter/pull/109148 (is it what you mean?). But it fails with the following error: ``` [flavors_test_win] [STDOUT] stdout: 00:14 +0 -1: loading C:\Users\DKWings\src\flutter\dev\integration_tests\flavors\integration_test\integration_test.dart [E] [flavors_test_win]...

Yes, it is initialized as `IntegrationTestWidgetsFlutterBinding`.

I'll review it today. Sorry about the delay.

I've asked @/goderbauer who will make a second review once my change requests are resolved.

@goderbauer The PR seems ready for a second review.

I'll have to check, but we don't need it for Android, because the Android native system uses a very simple stack-like behavior. We only need the batch information for iOS.

Great find! Thank you. Now it seems like the better solution is to change the engine API to deliver the batching information...

I'll take a look at the engine changes in the next few days. Eventually we'll want different behaviors for Android and iOS. But as the first step I think it's...