Daniel Kulp

Definitely concerned about the set->add change. That will certainly break peoples code. Can the original method be retained with the add method being added?

I don't think this is the "right" fix for this. The Soap w/ Attachement spec allows for http URL's for the cid and actually shows that use in the examples...

The main issue is that SOAP w/ Attachments doesn't have that limitation. Thus, applying that limitation in AttachmentUtils is not the right place unless an extra flag is passed in...

Nothing about this change will actually work. Changing to a WeakHashMap and using a "new String(...)" for the key will result in nothing actually holding onto the key and the...

I think adding a method to Client like: ``` default AutoCloseable autoCloseContexts() { return new AutoCloseable() { @Override public void close() throws Exception { getRequestContext().clear(); getResponseContext().clear(); } }; } ```...

Closing the entire client is very different (which we already support). When close on the client is called, EVERYTHING gets shutdown and cleaned up including conduit connections, pointers to the...

Possible suggestion - in outputCallback check the device to see if IT is shutdown prior to locking the mixer_lock: ``` SDL_AudioDevice *this = (SDL_AudioDevice *) inUserData; if (SDL_AtomicGet(&this->shutdown)) { return;...

Can this be re-based on master and determine if any of it is still needed?

Can you rebase this on master? Also, master is not c++11 so you can go back to using the c++11 things.

I don't have a non-Sonoma machine available right now, but it was originally reported to me from someone running Ventura so I know it's ocuring there as well. I'm not...