Dylan T.

Unhelpful errors on syntax issues

1

**Is your feature request related to a problem? Please describe.** Currently problems with action code can cause errors like this: ``` SyntaxError: Unexpected token '.' at new AsyncFunction () at...

String offsets are always considered invalid if they aren't strictly `int`

4

# Bug report I stumbled across this while working on phpstan/phpstan-src#311. In the test sample below, the given array _may_ have legal keys, but PHPStan doesn't think so. Without phpstan/phpstan-src#311,...

Verify validity of blockstate IDs at the SubChunk level

1

### Link to crashdump https://crash.pmmp.io/view/12469816 ### Additional comments (optional) I hoped we would never need to do this, but it seems like plugin devs insist on bypassing normal mechanisms and...

### Link to crashdump https://crash.pmmp.io/view/12805593 ### Additional comments (optional) This looks like a plugin incorrectly constructed items to set in the inventory instead of using `VanillaBlocks::GRASS()->asItem()`. It should not be...

Always use `Permission` objects instead of `string`

1

## Problem description There are various places where strings have to be looked up as permissions before using them: https://github.com/pmmp/PocketMine-MP/blob/8cdc7d7ee16482d630e49af2765dc958062b8693/src/permission/PermissibleInternal.php#L142 https://github.com/pmmp/PocketMine-MP/blob/8cdc7d7ee16482d630e49af2765dc958062b8693/src/permission/PermissibleInternal.php#L191 https://github.com/pmmp/PocketMine-MP/blob/8cdc7d7ee16482d630e49af2765dc958062b8693/src/plugin/PluginManager.php#L191 https://github.com/pmmp/PocketMine-MP/blob/8cdc7d7ee16482d630e49af2765dc958062b8693/src/command/Command.php#L106 This is problematic because it requires redundant...

### Problem description None of our integration tests currently pick up on errors in lazily-loaded components, unless the lazy loading happened to be triggered. This is a pain because users...

### Problem description Currently we only require the player's spawn chunk to be generated if they're a new player trying to find a safe spawn. We do _not_ do this...

NetworkSession: add support for discarding repeated packets before th…

2

…ey're decoded this dramatically reduces the server workload dealing with spammy packets like right-click interactions trigger. It also solves the problem of players getting kicked for right-clicking for too long....

### Link to crashdump https://crash.pmmp.io/view/12754024 ### Additional comments (optional) I presume that's what caused this crash anyway... Regardless, EntityExplodeEvent apparently needs to check that the targets are within the world...

### Link to crashdump https://crash.pmmp.io/view/12741527 ### Additional comments (optional) We really shouldn't allow `close()` to be called directly as a general rule. Probably needs to come under #5437, although we...