sanic-prometheus icon indicating copy to clipboard operation
sanic-prometheus copied to clipboard

Fix compatibility with Sanic 21.12.0+

Open jmarcet opened this issue 2 years ago • 4 comments

The deprecation is now an error with current Sanic 21.12.0

Would you mind to include the fix?

jmarcet avatar Jan 05 '22 12:01 jmarcet

Is there any timeline for merging this?

anna-hope avatar Jan 21 '22 19:01 anna-hope

In __init__.py lines 134 and 144 app.memcollect_task should be changed to app.ctx.memcollect_task as these are still causing errors.

https://github.com/dkruchinin/sanic-prometheus/blob/24c15860c3e133a416868f15567ccd2577e0d2e1/sanic_prometheus/init.py#L132-L145

anttilip avatar Feb 08 '22 18:02 anttilip

Are you still working on this? @jmarcet

erickg-k avatar Jun 02 '22 08:06 erickg-k