Dmitry Kropachev

Results 287 comments of Dmitry Kropachev

> > @sylwiaszunejko , please take a look at `job/scylla-drivers/job/gocql/job/advanced-ci-cd/job/longevity-large-partition-asymmetric-cluster-3h-test/` > > shouldn't it be named `extended-ci` instead of `advanced-ci-cd` for consistency with the label and dockerhub repo? https://hub.docker.com/r/scylladb/gocql-extended-ci/tags Done

> @dkropachev is https://github.com/scylladb-actions/jenkins-client an official location for this action? It is not, but it shouldn't matter since it is an GitHub action.

> Tested the new job for CI with various nemesis_seeds (in order to fix it with a specific one later): https://argus.scylladb.com/tests/scylla-cluster-tests/1adffeeb-28ac-432c-a6f8-8477b70fa557 For now it seems like the CI job is...

> I am not sure about the recreate tests, I only change the strategy in testdata/recreate files and used `updateGolden` option to automatically update golden files but the changes does...

> For example lack of `'replication_factor': '2'` in keyspace_golden.cql was something I was not sure about, but I guess `'datacenter1': '2'` means that in this dc replication factor is 2,...

> > Modify `Statement` classes to provide table name alongside already implemented keyspace name, in order to detect if CDC partitioner should be used for a given `Statement`. > >...

As I understand it was done to signal upper logic to connect only to a certain number of remote dc nodes. My proposal, instead of going around the code and...

> I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at. https://github.com/scylladb/python-driver/issues/370

> Nit: it is a good practice to have all commits passing tests. IIUC the first commit changes used Scylla version, which breaks some tests, and subsequent commits fix this...

> xfail_scylla_version_lt Fixed.