python-driver
python-driver copied to clipboard
scylladb
Bring python 3.13 into integration tests
It is resurrection of https://github.com/scylladb/python-driver/pull/336
Brings python 3.13 to the integration tests.
Updates scylla to 5.4 and switches from gabrielfalcao/pyenv-action@v16 to actions/setup-python@v5
I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at.
I've read somewhere that 3.13 optionally / experimentally removes the GIL. Would be good to test without it, to see where we are at.
https://github.com/scylladb/python-driver/issues/370
Nit: it is a good practice to have all commits passing tests. IIUC the first commit changes used Scylla version, which breaks some tests, and subsequent commits fix this breakage. If this is true, then could you move first commit to be the last? That would keep all commits passing.
It is good idea, but, reality is that full test suit takes 30 minutes to complete, say you have 5 commits, it means that I have to spend 150 minutes on testing them.
Now, say I want to change something in the partilar commit, I have to go back to the commit I am changing, spend 30 minutes on testing it and, if code I have changed is not isolated, I have retest every commit that goes after it, does it worth it ? I think no
Sure, it is not practical to run integration tests on each commit right now, because they take too long. But:
- imo it is still worth it to try and have commits without braking tests - it makes it easier to read such commits and if there is a need to bisect something, there will be less fixing to do (even if there still is some fixing)
- running unit tests will catch a lot of problems and is much faster.
@dkropachev we need this merged, without this one, and the move to use scylla 5.4, we can't install scylla anymore. cause of the java lookup is broken
@fruch , plan is to merge last pending PR: https://github.com/scylladb/python-driver/pull/397, rebase this PR and see what is left, which should be only pipeline changes.
@fruch , @Lorak-mmk after all rebases it is left only with python-related changes please take a look.