Markus Friedrich

Pull request apparently got lost somehow, code and review annotations look good to me though, so I'll merge now. I'll port this to release-11.5.x

I think @dkd-kaehm is right, the hook `preAddModifyDocuments` is called in `Indexer->indexItem()` which isn't called by the `PageIndexer`. The `PageIndexer` is based on the `Indexer`, but has an own implementation...

> But this did not work in an early version either? I'm not quite on the subject, but I think that's the case. For me it looks like the indexPagePostProcessPageDocument...

Estimation: Effort: 13 Value: 13

Already merged /done in 2001 (#3013 ), I'm closing this issue

Fixed with https://github.com/TYPO3-Solr/ext-solr/pull/3484 and https://github.com/TYPO3-Solr/ext-solr/pull/3475

I am closing this PR as the problem has been resolved in the meantime, see https://github.com/TYPO3-Solr/ext-solr/pull/3539

Unfortunately, we overlooked in this discussion that while `preAddModifyDocuments` does actually not work, there are 3 hooks that could be used: ``` $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPagePostProcessPageDocument'] $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageSubstitutePageDocument'] $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageAddDocuments'] ``` We plan to merge...

I agree, we should check and handle such configurations correctly. Currently EXT:solr requires a timestamp field, the timestamp is used to determine if a record has changed and has to...