Samuel Seng comments

Results 5 comments of


                                            Samuel Seng

Installation Error

> Found the problem. I had installed Java 8 correctly but my system was still using the default Java 11 install. All I had to do was manually switch to...

Update 01_intro.ipynb - IMDb reviews sentiment analysis prediction output change

LGTM! This undoes this incorrect change https://github.com/fastai/fastbook/commit/bb0dadf1ec360b957a6ba512da952aef6b69091e#diff-2797ef6b1a7e774fb61038401a8b5d7a9da91f43da3744f3ed6dc18796126074R2265 (Expand the diff for 01_intro.ipynb and it should jump to line 2265)

Update 01_intro.ipynb - IMDb reviews sentiment analysis prediction output change

> @djsamseng, thanks for reviewing it. Will you be merging it or should we ping someone else? Yeah ping one of the owners as I don't have merge privileges

Switch back to gpt2 512 model. Fixes gibberish gpt2 output

> Hi , I want to try: > > ``` > private let model = gpt2_512() > public let tokenizer = GPT2Tokenizer() > public let seqLen = 512 > ```...

Switch back to gpt2 512 model. Fixes gibberish gpt2 output

Should be this one [https://github.com/huggingface/swift-coreml-transformers/blob/master/Resources/gpt2-512.mlmodel](https://github.com/huggingface/swift-coreml-transformers/blob/master/Resources/gpt2-512.mlmodel)