David Koloski

Results 219 comments of David Koloski

I think this RFC may exacerbate existing problems with name resolution. If a refined impl is semantically equivalent to an inherent impl with the refined signature plus a trait impl...

Here's one example where I think refined return types cause confusion. Starting from a relatively egregious example that has nothing to do with trait refinement: Click to expand ```rust trait...

https://github.com/hyperium/h2/pull/616 should fix the nightly CI.

Sorry, I didn't put enough context in here. https://github.com/hyperium/hyper/pull/2830 contains some work to remove a transmute from hyper. Rather than write new `Buf` impls with `unreachable!`, I figured we could...

Bumping this after #616 was merged.

Quick bump on this, if there are no objections I think this would be a good improvement. 🙂

I actually think that using an `&mut [u8]` would resolve this issue since the mutable references have to be _simultaneous_ to violate the aliasing rule. You can still have an...

Hm, that's true. It seems like this kind of external shared memory is not something Rust was intended to work with natively. I do still think that using a mutable...

If a type has interior mutability and produces a mutable reference to some internal value, then it must ensure that the reference obeys the typical aliasing rules. For example, `RefCell`...

I think the PR looks good in general. Because of the reliance on libc, I think this would be better suited for [rkyv_contrib](https://github.com/rkyv/rkyv_contrib) if you wanted to upstream it. I...