Dustin H

Results 48 comments of Dustin H

Hey I'm still reviewing this! Was trying to fix my local build environment (Microsoft has gone and changed their docker images). Once I've got it building, I'll test it out....

When I have some time I'll see if I can add building for both x32/x64 in the travis/releases.

I'm not confident this is a backwards compatible change since it removes a method. It might not break our library, but that doesn't mean it doesn't break clients of our...

Missing currently: `android hurd illumos ios zos ` None of those have implementation hints in Go std lib afaik, will maybe need some manual digging to find if they have...

We also are limited in testing to those envs which [TravisCI supports](https://docs.travis-ci.com/user/reference/overview/).

Looks like it's loading the manager that is the 'slow' part: https://github.com/lspvic/jupyter_tensorboard/blob/5d6fa13ecfeb27ee446ed8533c5236e21ba79b3a/jupyter_tensorboard/handlers.py#L22 Looks like even in a 'warmed' env (jupyter notebook run a few times), this adds ~2s. Wonder if...

And from there the slowdown is caused by: https://github.com/lspvic/jupyter_tensorboard/blob/5d6fa13ecfeb27ee446ed8533c5236e21ba79b3a/jupyter_tensorboard/tensorboard_manager.py#L19 Source: https://github.com/tensorflow/tensorboard/blob/master/tensorboard/default.py

You might consider using the [select](https://tour.golang.org/concurrency/5) statement on the ticker and KbpsChan to make sure the reads/writes are synchronized.

My temp directory is on my SSD, so it looks like that's what I've been testing against.

There's where my performance lands on the SSD on my mac as well. I double-checked, my C: is my SSD and that's where the benchmark is being run. What OS...