Dirkjan Ochtman
Dirkjan Ochtman
If I'm not mistaken, JSON output will always be UTF-8. However, as far as I know from the API, the `to_string{,_pretty}()` and `to_vec{,_pretty}()` functions allocate a new string buffer and...
I'm using release Firefox on macOS, and I've been using the search extension for a long time. Since a few weeks, searching using the `rs` prefix for the std docs...
```rust use std::borrow::Cow; use async_graphql::{Interface, Object, Union}; #[derive(Union)] enum DnsUpdateError { Generic(GraphqlError), } #[derive(Interface)] #[graphql(field(name = "message", type = "Option"))] enum GraphqlError { Generic(GenericError), } struct GenericError { message: Cow
I have not added any tests so far. I did check the benchmarks and this seems to result in a ~3% improvement in the large streams benchmark.
This will hopefully clarify our best practices and requirements, making review rounds quicker.
The comment here is a bit cumbersome, describing more what the function does than what its purpose or conceptual contract is about. The body consists of a pretty dense iterator...
```rust fn set_key_discard_timer(&mut self) { let duration = self.pto() * 3; } fn detect_lost_packets(&mut self) { let rtt = self.path.rtt.get(); let loss_delay = cmp::max(rtt.mul_f32(self.config.time_threshold), TIMER_GRANULARITY); let congestion_period = self.pto() *...
The current API is pretty confusing because it requires passing in a `Side`, but it's not obvious if that is the API user's side or the message originator's side. My...
QUIC v1 will not include support for multipath traffic, but it is already being discussed. In particular, there's an Internet Draft here: https://datatracker.ietf.org/doc/draft-deconinck-quic-multipath/?include_text=1 This issue will help us keep track...
Our Rust API is currently completely abstract over types that implement the `Point` trait: ```rust pub trait Point: Clone + Sync { fn distance(&self, other: &Self) -> f32; } ```...