Dirkjan Ochtman
Dirkjan Ochtman
I think this should target the 0.24 branch. Is there an issue about this? If so, suggest mentioning it in the PR description.
(Changed base branch to dev-0.24.)
I proactively merged main into dev-0.24, so this needs to rebase -- then Joe's commit should fall away.
@AnickaBurova would be great if you can respond to the issues filed against your repository.
> I think I'll just pull the library from crates.io. I originally made it for myself and thought others might find it useful too, but if it could cause issues,...
Let's not do an advisory in that case. Thanks!
> Deduplication and caching features should be added to `DnssecClient`, to bring it to parity with the recursor, and avoid wasted network traffic. I don't think `DnssecClient` is a particularly...
I like this idea a lot but not entirely sure it's workable? The problem (so far) ends up being the `LookupRecords::ManyRecords` variant, which collects a `Vec` and thus makes it...
`quinn::Connection::send_datagram()`: > Transmit `data` as an unreliable, unordered application datagram > > Application datagrams are a low-level primitive. They may be lost or delivered out of order, and `data` must...
Fair enough. Suggest adding a method `quinn_proto::Datagrams::retain(impl Fn(&Datagram) -> bool)` (below `send()`) which directly calls `self.conn.datagrams.outgoing.retain()` (and makes sure to update `self.outgoing_total`while running). Then, add a similar `retain_datagrams()` to `quinn::Connection`.