Dirkjan Ochtman
Dirkjan Ochtman
Would you be able to submit a PR?
In particular, context: > The most recent commit implements this -- this required changing all of the lookup and search call sites in the server to work, but take a...
I'm sympathetic to the idea that this isn't the best solution, but I also think `LookupError::NotHandled` would be confusing too -- `NotHandled` doesn't feel like an error case to me....
We can of course add some of our own helper methods to the enum definition, of course.
I resolved some of my comments -- @marcus0x62 have you looked at it? I think we could merge this if that was resolved.
> I've been thinking about this change, and I'm really torn on the wrapped error/result type... I understand the reason we ended up here, but something feels wrong with wrapping...
@bluejekyll I think you should just pronounce. I think I still slightly prefer the trivariant type but it's clearly not a mortal lock either way.
Your analysis makes sense to me. Maybe it makes sense to reuse the std ControlFlow type somehow?
`ControlFlow` feels pretty complex but I guess the complexity is warranted here if we do have different envisioned semantics for all 5 cases? We could flatten it into a custom...
I think I like this proposed `LookupResponse` (a little bit) better than `ControlFlow`, because as something domain-specific the variant semantics are a little easier to infer than if we used...