Dirkjan Ochtman
Dirkjan Ochtman
Would be nice to have!
@alexrudy and @ikrivosheev thanks for all your work on this! I'm going to be helping @LucioFranco out with tonic reviews, and obviously this is a desirable change. As such, I've...
> @djc Thanks so much for your initial comments. > > Overall, I tried to minimally scope the changes here based on what was required to make the tests pass...
The separate PRs have been merged -- will go through this again once it has been rebased.
> This is a particularly painful kind of review for me, since I'm not sure that it consistently moves this PR towards being ready to merge, so I'll address your...
This makes sense to me, sorry for the long delays!
There's really no need to merge this -- the change is semver-compatible, so your downstream applications can upgrade to the new version without cooperation from tonic.
Going to close this, since downstream consumers can pick up the updated h2 version without waiting for us.
> > @mkatychev you just need to run `cargo run --package codegen` > > Hi @LucioFranco I did that with the given version of protoc (25.1) on macOS and I...