Dirk Brink
Dirk Brink
+1 I'm also seeing PUSH0 opcodes in opcode output artefacts when specifying EVM version paris. Below is a Makefile test that caught the stray PUSH0 instructions: ``` test-push0: forge build...
Thanks for looking into this @DaniPopes! Based on the above, I would expect the following foundry config settings to remove the PUSH0 opcodes from the output artifacts: ```toml cbor_metadata =...
> @djb15 That should be the case, are you sure you're on `evm_version = "paris"`? @DaniPopes Yeah sorry for not being more clear! I'm using `evm_version = "paris"`, but I...
@DaniPopes Thanks for your help! Yeah the build info output is aligned with forge so looks like it's a solc problem still writing the metadata to the extra opcode output...will...
Closing as part of cleanup. The branch can be retrieved [here](https://github.com/wormhole-foundation/wormhole-branch-clone/tree/evm/upgrade-automatic-relayers-mainnet-wip) and the PR reopened from a fork if required.
> If this test is valuable, should it be run in CI alongside the others? I was concerned about tying CI to an RPC given we're forking mainnet for this...
Closing as part of cleanup. The branch can be retrieved [here](https://github.com/wormhole-foundation/wormhole-branch-clone/tree/differential-fuzzing) and the PR reopened from a fork if required.
> > @djb15 - I saw this comment and wanted to note that I don’t believe secrets for this repo would be available to PRs from forks, so I would...
Closing as part of cleanup.
Closing as part of cleanup. The PR can be reopened if required.