django icon indicating copy to clipboard operation
django copied to clipboard

Prefer compact coding in json_script

Open mymedia2 opened this issue 1 year ago • 2 comments

json.dumps() overrides ensure_ascii=False in DjangoJSONEncoder. Set the flag again. It is okay because JSON allows the use of Unicode characters only. Set separators without spaces as well.

mymedia2 avatar Jul 19 '22 15:07 mymedia2

Hello @mymedia2! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

github-actions[bot] avatar Jul 19 '22 15:07 github-actions[bot]

@mymedia2 Thanks for this PR :+1: It's a new feature and all new features require an accepted ticket, please create one. Moreover it's backward incompatible so release notes are also needed (see a similar change, ticket-29249).

felixxm avatar Jul 21 '22 05:07 felixxm

Closing due to inactivity and lack of follow up.

felixxm avatar Aug 16 '22 08:08 felixxm