django icon indicating copy to clipboard operation
django copied to clipboard

Fixed #33865 -- Optimized LimitedStream wrapper.

Open ngnpope opened this issue 1 year ago • 2 comments

ticket-33865

ngnpope avatar Jul 23 '22 17:07 ngnpope

See the ticket for benchmark scripts and output. Basically this makes LimitedStream.read() ~1.25x faster and LimitedStream.readline() ~2x faster \o/

ngnpope avatar Jul 23 '22 17:07 ngnpope

Thanks @apollo13. I'm away for a couple of weeks, so will get back to this then.

ngnpope avatar Aug 03 '22 18:08 ngnpope

Rebased and marked ready for review again. See my comments above - I don't think we need to do anything further here but, if we do, it should be a separate ticket.

ngnpope avatar Jan 04 '23 11:01 ngnpope

I'm pretty sure this is fine but, do we want to merge it after the feature freeze, so we get the whole 5.0 cycle for any issues to appear. (5.0 also isn't LTS so...)

Quick chat with @felixxm, let's have it this time.

@ngnpope Let me know on the other points and we'll push it forwards. Thanks!

carltongibson avatar Jan 05 '23 12:01 carltongibson

Ok @carltongibson. Have updated following your review.

ngnpope avatar Jan 05 '23 15:01 ngnpope

@ngnpope Thanks :+1:

felixxm avatar Jan 05 '23 18:01 felixxm