disksing comments

Results 61 comments of


                                            disksing

backoff: export errors

LGTM. Please rebase latest master. There are some files are moved to another directory.

anyways to lock a key, read the key, update the key and unlock the key? this is for incremental +1 update to the value

if you use the txnkv api, updating the key in a transaction should be sufficient. for rawkv api, you can consider using `CompareAndSwap`. Be aware that it cannot avoid the...

cluster: move stats update into a better place

I think even if update statistics in heartbeat, it can still lose sync.

server: the logs in client-go are not fully red-acted

you mean we should print in hex format?

Let PD check regions before splitting regions

After notify, PD does not fix regions immediately. Do we need to check all regions become healthy before scatting them?

Let PD check regions before splitting regions

> @disksing Maybe we can check region before splitting table in TiDB. If the region count of this table is 1 and its replicas number is 4 (yet only need...

How to use SDK to access RawKV from outside the k8s cluster?

I am not familiar with k8s, but I think maybe you can bind a domain name for each tikv node and PD node so that they can be accessed from...

How to use SDK to access RawKV from outside the k8s cluster?

This idea sounds interesting to me. I did some research and found that grpc provides the ability to customize name resolver functions (https://github.com/grpc/grpc-go/blob/master/examples/features/name_resolving/README.md) If possible, I think we can add...

DATA RACE in the internal/unionstore.(*MemDB)

@hawkingrei I think MemDB is not designed to allow accessing by multiple goroutines. So tidb may need some lock to avoid data race.

DATA RACE in the internal/unionstore.(*MemDB)

@hawkingrei could you confirm if the tidb you are using contains the patch #585 ?