MS
MS
This looks great! A lot more sophisticated than the `ImportSymbolsScript.py` that comes with Ghidra. The `isledecomp` package is for python 3, so if that's ultimately a blocker for integrating with...
We are parsing type info, but it's not as accessible as the other stuff for two reasons: - it's outside of the main "compare database", as you see from `datacmp.py`...
Yes, definitely. But not much time to dig in and actually run it until the end of the week. I skimmed through it quickly earlier today. One thing about the...
Without trying any of the new stuff (yet), here's why the current unit tests fail: - Line 366 should be `return self.get(normalize_type_id(underlying_type))`. The test `test_enum` expects the type alias to...
If I build `mxdsmultiaction.cpp.s`, it shows this for the stack: ```asm ; COMDAT ?SetAtomId@MxDSMultiAction@@UAEXVMxAtomId@@@Z _TEXT SEGMENT $T14029 = -16 __$EHRec$ = -12 _p_atomId$ = 8 _this$ = -36 _cursor$ =...
I just got around to actually trying out the plugin. Very impressive! Two things tripped me up, but just take these as observations if you prefer: - The `virtualenv` requirement....
[beta10-zero-ref-count.txt](https://github.com/user-attachments/files/21337282/beta10-zero-ref-count.txt) Here are the (known) functions from my local Ghidra with a Reference Count of 0, using the latest data imported from `reccmp`.
There's the chance that some `ScoreItem` structs are copied via direct assignment instead of explicitly calling `memcpy`. We've seen this in some of the other beta functions. The beta struct...
Looks like the beta used an `MxPtrList` for this class instead of STL types: ``` 100d0b00 --- LegoCacheSoundEntryList::LegoCacheSoundEntryList 100d0ba0 --- LegoCacheSoundEntryList::Compare 100d0be0 --- MxPtrList::MxPtrList 100d0c80 --- MxList::MxList 100d0d30 --- MxCollection::MxCollection...
The problem here is that the `vector` copy constructor is not inlined in `FUN_1002ad8a`. Although it appears second in the assembly, this is the first call to set `m_assAnim`. The...