isle icon indicating copy to clipboard operation
isle copied to clipboard

Match `LegoExtraActor::HitActor`

Open foxtacles opened this issue 11 months ago • 1 comments

foxtacles avatar Jan 11 '25 00:01 foxtacles

The problem here is that the vector<unsigned char*> copy constructor is not inlined in FUN_1002ad8a. Although it appears second in the assembly, this is the first call to set m_assAnim.

The code from VECTOR looks like this:

vector(const _Myt& _X)
	: allocator(_X.allocator)
	{_First = allocator.allocate(_X.size(), this);
	_Last = uninitialized_copy(_X.begin(), _X.end(), _First);
	_End = _Last; }

The call to size() is from this function, not the for loop.

What is not clear is why this happens and why entropy builds don't solve it. FUN_1002ad8a matches the beta fine (addr 0x10082400).

disinvite avatar Apr 05 '25 03:04 disinvite