Dirk Weissenborn

Results 23 comments of Dirk Weissenborn

Hi Tim, can you try downgrading to spacy 1.9 or change the stopword set to something else. For instance you can provide an empty set. However, I will try to...

I changed the spacy version in requirements back to 1.9. It was temporarily changed because there was a bug on spacys side. Compared to 2.x, spacy 1.9 is really fast...

Let's have a test for the method though. I'll keep this issue open.

No, not really. They happen when we backprop through a gather op.

search for "gather" in [1]. I don't know how easy it will be to change that. Can we not just suppress these warnings? [1] https://github.com/uclmr/jtr/blob/master/jtr/tasks/xqa/fastqa.py

Sounds like a good idea! I don't really understand though what you mean by implementing the tests? Maybe we need a registry for models with a corresponding default dataset. For...

it is easier if you just use the train method of the reader. You can also look at the train method to figure out how to train a TF reader,...

I think vocabs and emebddings could simply be created and loaded in the shared resources and not the modules. In the modules it would introduce unnecessary overhead for most implementations,...

I agree with the vocab part, but the embeddings can be provided separately already through the shared resources.