Dirk Groeneveld
Dirk Groeneveld
The `mitchell` init method uses no other parameters. I guess it uses `cutoff_factor`, but you basically never have to touch that one.
This sounds good to me. @epwalsh, any concerns?
I'm not sure what's going on here, but I suspect the problem is that you're running Windows. I don't think Windows is a supported platform for aristo-mini.
I will revisit this after https://github.com/allenai/catwalk/pull/84 is merged.
You were saying you're still hacking on this and I should not review it?
You are right. Then we need to make sure we compute this every time. On Fri, May 3, 2024, 08:45 Akshita Bhagia ***@***.***> wrote: > ***@***.**** commented on this pull...
@epwalsh , can you look at this as well? This gets all up in your code.
I did not know this about ahash. This bloom filter is the first program I ever wrote in Rust, and it probably shows. I would love to move to a...
A bunch of these have been merged, but this one is still open. What's next for this PR?
All of these improvements should also be merged into the standalone tool at https://github.com/allenai/bff.