Dirk Groeneveld comments

Results 200 comments of


                                            Dirk Groeneveld

Models loaded using the `from_archive` method need to be saved with original config

We need a `Model.to_params` API.

Allow seq2seq models to use multiple decoder layers

I'm not super familiar with that code, but it seems to me that you'll have to modify `LstmCellDecoderNet` to use two `LSTMCell`s instead of just one. You can modify `previous_state`...

Add read pre-trained bin file to Embedding

I am also interested in getting this done, but without a clear indication of what exactly the format is, I don't see how we can do it.

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

The extended positional embeddings would be great. I assume it would be relatively self-contained, just resizing the embedding matrix during model initialization?

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

Is this just about the warning? I think the tokenizers will tokenize just fine, but they want to print that warning. If you know of a way to silence the...

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

@niansong1996, any updates?

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

Is this something we could adopt as a metric in AllenNLP? The metric API would require that we pass in two strings (or two lists of strings), one with the...

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

There is no point in worrying about differences in the implementation of ROUGE while one method uses stemmed tokens, and another uses word pieces. Let's get a version running that...

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

Oh, I see that https://pypi.org/project/rouge-score/ does all of it, tokenization, stemming, the lot. Then it should be easy to use it in an AllenNLP metric.

Implement a ROUGE metric that faithfully reproduces the official metric written in perl.

@niansong1996, your implementation of `NEW_ROUGE`, it uses the Google package? Can you point me to that code? I want to see how hard it would be to make it an...