Dirk Hoffmann
Dirk Hoffmann
This solves the problem: Remove the session from the middleware and initialize the session in the $beforeRouteInit() method ``` $beforeRoutesInit(): void { $log.info("beforeRoutesInit call") this.app.use(session({ secret: "thisShouldBeLongAndSecret", resave: false, saveUninitialized:...
I see! Maybe, we let users only allow to add relative paths to there home directory. But then, we need to take care of relative paths pointing to a parent...
I think it's not a good idea to ignore any setting. There are some use cases where it makes total sense. Most enterprises host a dedicated or a shared repo....
Yes, exactly! You need manual tasks to do so. Some projects even checkin the settings.xml in the repo, with the part to copy and paste to the users settings.xml. But...
I don't see any technical problem adding a readonly attribute to the vaadin-radio-button. Adding it to the input field itself would be a violation. On semantical level, a readonly property...
I didn't get it with the statements about the underlying `` control? My comment is about the web component called `vaadin-checkbox` or `vaadin-radio-button`. It will be useful, if these components...
I think we should abstract this in a readonly state. It makes the most sense. If you think about the `input type"radio"` or `input type='checkbox'` the disable attribute is mostly...
Let me also mention one other benefit: In the current implementation of the flow component `RadioButtonGroup` you find a method which renders the radio buttons. If it renders readonly, there...
No, if you add a readonly Property in RadioButton itself, the logic could move into the RadioButton itself. Where it belongs. You need to take care of the checked and...
I get quite another concern. If this logic is already written in javascript, why is the same thing repeated in the `RadioButtonGroup` class in flow component? Is this a mistake?...