Dion Dirza

Results 20 comments of Dion Dirza

Check my solution here https://github.com/staylor/react-helmet-async/issues/37#issuecomment-482039791

This is really great to be implemented, yet it requires some changes to make it fully work

Ah sorry, you right. It is better to write it like that. I thought asyncBootstrapper was impure function that mutates App component state. I think the codes on your last...

If you look at the AB source code, it only triggers `asyncBootstrap` function inside our component.

Currently using the same setup as this PR in prod. This is good to be merged.

@Thammada have you tried to comment this line https://github.com/ctrlplusb/react-universally/blob/master/config/values.js#L66?, in my previous PR's commit https://github.com/ctrlplusb/react-universally/commit/94a61ecad0adccdd710d6133e6727f37840ba147 I have made some changes to not activate es6 feature from polyfill.io because the counter...

I have tried what @birkir said by adding this line and it works fine for iOS agent ``` scriptTag(`${config('polyfillIO.url')}features=${config('polyfillIO.features').join(',')}&flags=gated,always), ```

You should try to run this command `npm run analyze:client`, and see what dependency that has bloated your bundle size.

I think this is worth to have since vendor rarely change so we could have benefit for long term caching.

@ctrlplusb @birkir I know I can count on you guys. Preparing migration for my production to version 13 I guess.