Fabian Meyer

Results 19 comments of Fabian Meyer

How about removing the default User Agent from here: https://github.com/reactphp/http/blob/b5a66a4faa77f8e8ab0094566501b9f40cb5079e/src/Client/RequestData.php#L32 and re-adding it in the Browser constructor via your new `withHeader()` function? Then it should be easily removable with `withoutHeader()`....

Okay I will update to only handle 307/308, yes it's better to address these when they actually become problems (YAGNI again 😄 ). Actually I found this in the RFC...

Updated this PR to only handle 303, 307 and 308. 303 will be converted to GET. 307 and 308 will preserve their methods and body. All others should have the...

Nice yes I think this really simplifies it. I found this about how Chrome handles this with the fetch API: > Restricted redirects Some forms of HTTP redirect require the...

Hey I updated the PR with your suggestions and added an exception and a test. Please have a close look at the new test I'm not 100% sure if it's...

I'm not sure if the re-request review button worked you may now have no or quite a few requests 🤣

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests Can u maybe enable this on the repo or am I just not seeing this option? This would make it way easier to merge PRs. But I can also...

Everything squashed 😄 :shipit:

LGTM! I applied your suggestions 👍🏼

Oh I think I messed something up squashing I will fix this in the evening