Denis Žoljom comments

Results 379 comments of


                                            Denis Žoljom

Code coverage cannot be generated due to weird global CSS output

My hunch is that the way `$attributes` just 'happen' in the view files is what trips up the code coverage. Code coverage is basically walking through files and checking if...

Review/Improve case-insensitive handling of custom function lists

Is this related to my closed PR: #2391? I so I can reopen it so somebody can pick that up.

Dashboard Add New Site

I am working on a project where I need to parse yaml to json, and for yaml I think you would need http://pecl.php.net/ library. This could be added by default...

Dashboard Add New Site

> It isn't, the dashboard currently uses a library to read YAML in: > > www/default/dashboard/php/yaml.php This is some kind of a fork of a `spyc` library? I'm all for...

ContextHelper::is_in_function_call(): add basic tests

I mean, if the work has been done here, I see no reason for not adding it to WPCS. For me, the most demotivating thing that can happen when contributing...

WordPress-Extra: demand for exit/die to always use parentheses

The safest route without ruffling some feathers would be to create a make post, then wait for comments, and then introduce it. I'm always for aligning WPCS with official PHP...

ConstantsHelper::is_use_of_global_constant(): do not treat `use const` alias as global constant usage

Tbh I am not sure anybody is still using WPThemeReview sniffs (the standard hasn't been updated in 4 years from what I can see). I'd like to see if there...

ConstantsHelper::is_use_of_global_constant(): do not treat `use const` alias as global constant usage

I really don't think this will have a major impact to users 🤷🏼‍♂️ So it can be a patch or minor imo

Proposal: Change docblock line wrapping to 120 characters

I don't think there is an official process documented, but when we did the WPCS 3.0.0 changes that included tons of changes for the docs, we were doing them based...